Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate more 3.16 features #472

Merged
merged 4 commits into from
Dec 27, 2020
Merged

Incorporate more 3.16 features #472

merged 4 commits into from
Dec 27, 2020

Conversation

KamasamaK
Copy link
Contributor

@KamasamaK KamasamaK commented Dec 7, 2020 •
edited
Loading

Many changes have been made for the 3.16 release of LSP, so I've collected a lot of them.

Added

  • Change annotations for WorkspaceEdit (via ResourceOperation) and AnnotatedTextEdit
  • Linked editing (Fixes Support for textDocument/onTypeRename #469)
  • Opening and showing a document in the client user interface
  • Refresh support for code lenses and semantic tokens
  • Provide the client's locale in the initialize call
  • Preserve additional attributes on MessageActionItem
  • Capability to signal whether the client normalizes line endings
  • Insert text mode on CompletionItems
  • Insert/replace for CompletionItem text edits
  • Default behavior for prepare rename
  • Overlapping and multiline support for semantic tokens
  • Monikers (Fixes Support for Monikers #448)
  • Trace notifications (Fixes Support Trace notifications #455)
  • Regular expression engine support
  • Markdown parser support
  • Progress support for rename, color provider, folding range provider, and document range formatting
  • Missing properties on ApplyWorkspaceEditResponse

Removed

  • Non-standard feature Coloring is removed as it was already deprecated in favor of Semantic Highlighting which is itself deprecated in favor of Semantic Tokens (See Removing Semantic Highlighting #457)

Compatibility issues

  • Changed some types from Number to Integer
  • ProgressParams missing nullability checks
  • CompletionItem.textEdit now an Either

szarnekow
szarnekow reviewed Dec 8, 2020
View reviewed changes
Copy link

@szarnekow szarnekow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the effort, @KamasamaK .
I'm not a maintainer of lsp4j but a consumer thus I try to follow the changes that are made. I've to say this is a huge merge request. Unfortunately it mixes different changes (all towards 3.16, but still). Would it by chance be feasible to split that up into smaller digestible chunks?

I'm through with the review yet but wanted to post the first small batch of comments and trigger this discussion.

org.eclipse.lsp4j/src/main/java/org/eclipse/lsp4j/InsertTextMode.java Outdated Show resolved Hide resolved
org.eclipse.lsp4j/src/main/java/org/eclipse/lsp4j/MonikerKind.java Outdated Show resolved Hide resolved
org.eclipse.lsp4j/src/main/java/org/eclipse/lsp4j/Protocol.xtend Outdated Show resolved Hide resolved
org.eclipse.lsp4j/src/main/java/org/eclipse/lsp4j/Protocol.xtend Show resolved Hide resolved
Consistent indentation
e29dfdb 
Signed-off-by: Matthew Brown <[email protected]>
@KamasamaK KamasamaK added this to the v0.11.0 milestone Dec 8, 2020
This was referenced Dec 16, 2020
Closed
Closed
@nixel2007
Copy link
Contributor

Any chance to add DocumentSymbolOptions and label field?
p.s. thanks for your work!

Updated for finalization
af368bd 
Signed-off-by: Matthew Brown <[email protected]>
@KamasamaK KamasamaK changed the title Incorporate more 3.16 upcoming features Incorporate more 3.16 features Dec 22, 2020
Add back semantic highlighting
c83f6f8 
Signed-off-by: Matthew Brown <[email protected]>
@KamasamaK KamasamaK merged commit 5cc2304 into eclipse-lsp4j:master Dec 27, 2020
@KamasamaK KamasamaK deleted the lsp-3.16-pending-20201203 branch December 27, 2020 13:30
@ckipp01 ckipp01 mentioned this pull request Feb 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nixel2007 nixel2007 nixel2007 left review comments

@szarnekow szarnekow szarnekow left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.

Support for textDocument/onTypeRename Support Trace notifications Support for Monikers
3 participants
@KamasamaK @nixel2007 @szarnekow